Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrometheusMissingRuleEvaluations runbook #45

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aisbaa
Copy link

@aisbaa aisbaa commented Dec 6, 2022

@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for distracted-northcutt-e0bccc ready!

Name Link
🔨 Latest commit c00a82e
🔍 Latest deploy log https://app.netlify.com/sites/distracted-northcutt-e0bccc/deploys/63e66c4b8e41f60008257818
😎 Deploy Preview https://deploy-preview-45--distracted-northcutt-e0bccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aisbaa
Copy link
Author

aisbaa commented Dec 6, 2022

Not sure what failed in checks, for some reason logs are not available.

Copy link

@multani multani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aisbaa Thanks, I was also looking for this runbook!

I made some suggestion to improve the wording and add some additional links.

docs: add links to `rule_group`

Co-authored-by: Jonathan Ballet <[email protected]>
@aisbaa
Copy link
Author

aisbaa commented Feb 10, 2023

@multani this looks great! Thank you for adding! I'm new to this collaboration interface, should I commit? Or would you like to commit these suggestions?

@multani
Copy link

multani commented Feb 10, 2023

@aisbaa I'm not sure I can commit in your branch, but if you open the "File changed" tab at the top-right, you should be able to batch all the changes and commit them all at once.

docs: grammar fixes and style improvements

Co-authored-by: Jonathan Ballet <[email protected]>
@aisbaa
Copy link
Author

aisbaa commented Feb 10, 2023

Thank you, just did that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants