fixing duplicate services that are seperate only by casing #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One problem we've experienced is that when you register a service in consul it is case sensitive. so for example, registering
redis
andREDIS
will register 2 services. However the "gotcha" is that instances of EITHER service will tie to BOTH services.example:
This creates duplicate metric entries for consul_service_tag and consul_node_healthy metrics when in reality it shouldn't fail on this. I do say i mostly blame consul for the way its done, but from what i know it was done like that on purpose because that is how the DNS is going to work with consul (case INSENSITIVE).
This simple check looks to make sure the entry/instance (instance-2-REDIS) and its service name matches the service that we are looking up (REDIS service) aka
/v1/health/service/REDIS
. if the instance doesn't match (instance 2-redis) we skip it.