-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BalancerV3: SwapAdapter and Substreams #126
base: main
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14904727 | Triggered | Generic High Entropy Secret | 9ed26a6 | evm/test/BalancerV3SwapAdapter.t.sol | View secret |
14904728 | Triggered | Generic High Entropy Secret | 9ed26a6 | evm/test/BalancerV3SwapAdapter.t.sol | View secret |
14904729 | Triggered | Generic High Entropy Secret | 9ed26a6 | evm/test/BalancerV3SwapAdapter.t.sol | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
initialized_accounts: | ||
- "0xbA1333333333a1BA1108E8412f11850A5C319bA9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the vault contract? Could you please add a comment here describing why this is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment in 302d458
45eebca
to
957f4ed
Compare
d8fddab
to
f3da187
Compare
f3da187
to
3b4ab22
Compare
f844e1e
to
4d7f8ab
Compare
db617f7
to
8dbc3cb
Compare
SSIA