Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Code Analysis with Php Inspections fixes #1377

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Static Code Analysis with Php Inspections fixes #1377

wants to merge 45 commits into from

Commits on May 29, 2017

  1. Configuration menu
    Copy the full SHA
    6cced7b View commit details
    Browse the repository at this point in the history
  2. Case Mismatched

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    95894a5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bb2fc59 View commit details
    Browse the repository at this point in the history
  4. Use boolean

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    1adce5c View commit details
    Browse the repository at this point in the history
  5. iterator replase

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    1f3bcea View commit details
    Browse the repository at this point in the history
  6. use short syntax

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    4c17985 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9a875f0 View commit details
    Browse the repository at this point in the history
  8. Unnecessary double quotes

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    12bdca8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8047e71 View commit details
    Browse the repository at this point in the history
  10. Unnecessary parentheses

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    4da28e1 View commit details
    Browse the repository at this point in the history
  11. Unnecessary semicolon

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    2f233ea View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c8fc332 View commit details
    Browse the repository at this point in the history
  13. Use in array

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    04808a5 View commit details
    Browse the repository at this point in the history
  14. Simplify return

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    12c762e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5e07ff1 View commit details
    Browse the repository at this point in the history
  16. Remove unneeded 'else'

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    2cc5a70 View commit details
    Browse the repository at this point in the history
  17. String normalization

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    873400c View commit details
    Browse the repository at this point in the history
  18. 'switch' to 'if'

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    ecb52d5 View commit details
    Browse the repository at this point in the history
  19. Simplify ternary operator

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    91f703a View commit details
    Browse the repository at this point in the history
  20. Merge unset

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    54f56c0 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    d584ab9 View commit details
    Browse the repository at this point in the history
  22. Use elfise operator

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    bd2ebd6 View commit details
    Browse the repository at this point in the history
  23. Use null comparation

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    3887227 View commit details
    Browse the repository at this point in the history
  24. Use type casting

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    945b6ac View commit details
    Browse the repository at this point in the history
  25. Reports array_push(...) calls behaving as '$array []= ...'. ' []= ' w…

    …orks faster than invoking functions in PHP.
    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    dac7c9a View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    9f67f07 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    567f0bb View commit details
    Browse the repository at this point in the history
  28. Reported cases can be refactored by using case-sensitive functions st…

    …rstr(...)/strpos() for better performance because matched patterns does not contain any characters.
    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    6635327 View commit details
    Browse the repository at this point in the history
  29. A 'substr()' call can behave as array access, but hiding some error-h…

    …andling logic behind as well. Using array access is a preferred way, because you have to implicitly write (read as document) errors handling code.
    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    aff77e7 View commit details
    Browse the repository at this point in the history
  30. Some of call_user_func()/call_user_func_array() might have semantic o…

    …f variable function call. Using variable function instead is a micro-optimization.
    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    362caaa View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    0243b2a View commit details
    Browse the repository at this point in the history
  32. A number of parameters, their names or types (if any) in PHPDoc comme…

    …nt do not match the ones in respective function or method declaration.
    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    68344f3 View commit details
    Browse the repository at this point in the history
  33. Analyzes uniqid calls and reports if both parameters are not provided…

    …. Prefix usage aids in identifying the source of the ID within the code and the more_entropy parameter improves randomness.
    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    c66836e View commit details
    Browse the repository at this point in the history
  34. fix reviews

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    9e93c43 View commit details
    Browse the repository at this point in the history
  35. fix review

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    a734ea5 View commit details
    Browse the repository at this point in the history
  36. optimize imports

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    41a683b View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    108c66a View commit details
    Browse the repository at this point in the history
  38. Reports 'is_null(...)' usage, a feature introduced in PHP4. All 'is_n…

    …ull(...)' calls can be safely replaced with 'null === ...' constructs (or 'null !== ...' if the original construct was negated).
    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    0af090a View commit details
    Browse the repository at this point in the history
  39. Analyzes str_replace(...) calls and reports when the function has bee…

    …n applied to a variable sequentially.
    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    636e141 View commit details
    Browse the repository at this point in the history
  40. fix sprintf param

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    aa09548 View commit details
    Browse the repository at this point in the history
  41. try to fix sqlite tests

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    c4b064a View commit details
    Browse the repository at this point in the history
  42. try to fix sqlite tests2

    gulaandrij committed May 29, 2017
    Configuration menu
    Copy the full SHA
    71c4a22 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2017

  1. try to fix sqlite tests3

    gulaandrij committed May 30, 2017
    Configuration menu
    Copy the full SHA
    7394075 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc24753 View commit details
    Browse the repository at this point in the history
  3. recheck

    gulaandrij authored May 30, 2017
    Configuration menu
    Copy the full SHA
    b6fac96 View commit details
    Browse the repository at this point in the history