Fixed relative template path assumption #1513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is currently written, it's difficult to write behaviors and specify a template dir since it's using the __DIR__ constant, effectively making it relative. The change keeps the same defaults, but expects a full absolute path, as it should be.
|
Is there a test case along with those changes maybe? |
Incognito
suggested changes
Jul 13, 2020
| if (!$templateDir) { | ||
| $filePath = __DIR__ . '/templates/' . $filename; | ||
| } else { | ||
| $filePath = $templateDir . $filename; |
There was a problem hiding this comment.
I really like the style used in https://github.com/propelorm/Propel2/pull/1491/files where the code uses realpath which would be less error-prone. Can we do something like that in this method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is currently written, it's difficult to write behaviors and specify a template dir since it's using the DIR constant, effectively making it relative. The change keeps the same defaults, but expects a full absolute path, as it should be.