Test for David Conrad

[daiconrad]

I implemented the methods as requested. I also decided to significantly alter the Person class to make it immutable and not allow null for name, address, or phone number. Avoiding null, where possible and appropriate, is a good thing. I added an allPeople() method to the PhoneBook interface to allow iterating over a (read-only) view of the contents of the phone book. I could have implemented the database calls using raw JDBC calls, but typically that is hidden behind Spring, Hibernate, or at least Apache Commons DbUtils these days. I didn't want to make major alterations to the project for what is supposed to be a quick test, so I just added DbUtils to the project. Let me know if you would like to see the database calls rewritten using raw JDBC calls. Finally, I added a few static methods to look people up in the database, just to show what that would look like. If I have misunderstood any part of what was desired, let me know. All the best, David Conrad.

[proquestinterview]

Hey David, this looks really good, do you have a current resume?

On 6/18/12 3:47 PM, "David Conrad"
<reply+i-5132097-e1baa2175fa0da5476e4d17d54820f61ab80edb2-1713689@reply.git
hub.com> wrote:

I implemented the methods as requested. I also decided to significantly
alter the Person class to make it immutable and not allow null for name,
address, or phone number. Avoiding null, where possible and appropriate,
is a good thing. I added an allPeople() method to the PhoneBook interface
to allow iterating over a (read-only) view of the contents of the phone
book. I could have implemented the database calls using raw JDBC calls,
but typically that is hidden behind Spring, Hibernate, or at least Apache
Commons DbUtils these days. I didn't want to make major alterations to
the project for what is supposed to be a quick test, so I just added
DbUtils to the project. Let me know if you would like to see the database
calls rewritten using raw JDBC calls. Finally, I added a few static
methods to look people up in the database, just to show what that would
look like. If I have misunderstood any part of what was desired, let me
know. All the best, David Conrad.

You can merge this Pull Request by running:

git pull https://github.com/daiconrad/webapptest master

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

• Test for David Conrad; refactor Person, implement unimplemented methods
  plus a few extras, added tests, use commons-dbutils

-- File Changes --

M .classpath (19)
A lib/commons-dbutils-1.4.jar (0)
M src/com/proquest/interview/phonebook/Person.java (86)
M src/com/proquest/interview/phonebook/PhoneBook.java (7)
M src/com/proquest/interview/phonebook/PhoneBookImpl.java (161)
M src/com/proquest/interview/util/DatabaseUtil.java (11)
M test/com/proquest/interview/phonebook/PhoneBookImplTest.java (56)

-- Patch Links --

https://github.com/proquestinterview/webapptest/pull/1.patch
https://github.com/proquestinterview/webapptest/pull/1.diff

---

Reply to this email directly or view it on GitHub:
#1

[daiconrad]

Sure. You can get it from http://www.codedazure.com/resume/Resume%20-%20David%20Conrad.doc

Or, if you prefer, let me know where you would like me to email it.

[proquestinterview]

David,

You were the first person who has actually done this (forking the test and
sending it to me directly), so our HR dept seems rather confused by this
process :-)

If you would, could you fill out the application here:
http://sj.tbe.taleo.net/SJ11/ats/careers/apply.jsp?org=PROQUEST&cws=1 I've
talked to HR here, and they'll keep an eye out for your application/resume.

Put my name (Rob Conklin) in the "Referred By" field in "How did you learn
about this opportunity?" section.

Looking forward to talking to you,

Rob Conklin, Lead Software Architect
ProQuest | 789 E. Eisenhower Parkway, P.O. Box 1346 | Ann Arbor MI
48106-1346 | 734.707.2084
[email protected]
www.proquest.com

ProQuest...Start here. 2011 InformationWeek 500 Top Innovator

On 6/18/12 4:18 PM, "David Conrad"
<reply+i-5132097-e1baa2175fa0da5476e4d17d54820f61ab80edb2-1713689@reply.git
hub.com> wrote:

Sure. You can get it from
http://www.codedazure.com/resume/Resume%20-%20David%20Conrad.doc

Or, if you prefer, let me know where you would like me to email it.

---

Reply to this email directly or view it on GitHub:
#1 (comment)
4

[proquestinterview]

http://nextstar.onjira.com/browse/PQ-1209