-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorting issue #30 #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @milanych! Thank you kindly for adressing this issue 🙌 Overall the code looks good, and I'll go ahead and test it once the changes in this review have been adapted. Please use pnpm to follow the existing project structure. 👍 Thanks!
Update: You may also want to merge lastest commit on main
👍
@Codeshark-NET Morning, I finally fixed this Husky issue for my Win10. Hope everything is good now. |
Looks good @milanych , thanks! I'll test it out when I get a chance, and approve if everything is good. 👍 |
Epic! Looks great! |
Congrats on your first PR @milanych 🙌 I ran "prettier" on the code, to fix the linting errors, but otherwise great. 👍 Thanks a lot! |
@Codeshark-NET @milanych I just realise that the "By project Age" filter is lost. 😟 . Any reason this was removed? I think this filter is relevant because some people want to contribute to a new project rather than fixing old ones. |
@Codeshark-NET We have now 3 filters: by Age, by Downloads, and by Stars. What do you mean? |
So we need 4 buttons, right? "Recent", "Age", "Downloads", "Stars" ? |
Yes that sounds right 👍 |
I'm not sure if a new user will be able to understand these shortened versions. Maybe recent issues, project age, downloads and stars? |
No description provided.