Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting issue #30 #38

Merged
merged 6 commits into from
Mar 5, 2024
Merged

sorting issue #30 #38

merged 6 commits into from
Mar 5, 2024

Conversation

milanych
Copy link
Contributor

@milanych milanych commented Mar 4, 2024

No description provided.

@andrew andrew requested a review from Codeshark-NET March 4, 2024 16:24
Copy link
Member

@Codeshark-NET Codeshark-NET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @milanych! Thank you kindly for adressing this issue 🙌 Overall the code looks good, and I'll go ahead and test it once the changes in this review have been adapted. Please use pnpm to follow the existing project structure. 👍 Thanks!

Update: You may also want to merge lastest commit on main 👍

@milanych
Copy link
Contributor Author

milanych commented Mar 5, 2024

@Codeshark-NET Morning, I finally fixed this Husky issue for my Win10. Hope everything is good now.

@Codeshark-NET
Copy link
Member

@Codeshark-NET Morning, I finally fixed this Husky issue for my Win10. Hope everything is good now.

Looks good @milanych , thanks! I'll test it out when I get a chance, and approve if everything is good. 👍

@Codeshark-NET Codeshark-NET merged commit 85078cf into protontypes:main Mar 5, 2024
1 check passed
@Ly0n
Copy link
Member

Ly0n commented Mar 5, 2024

Epic! Looks great!

@Codeshark-NET
Copy link
Member

Congrats on your first PR @milanych 🙌 I ran "prettier" on the code, to fix the linting errors, but otherwise great. 👍 Thanks a lot!

@Ly0n
Copy link
Member

Ly0n commented Mar 5, 2024

@Codeshark-NET @milanych I just realise that the "By project Age" filter is lost. 😟 . Any reason this was removed? I think this filter is relevant because some people want to contribute to a new project rather than fixing old ones.

@milanych
Copy link
Contributor Author

milanych commented Mar 5, 2024

@Codeshark-NET We have now 3 filters: by Age, by Downloads, and by Stars. What do you mean?

image

@Codeshark-NET
Copy link
Member

The age there is the "most recent issues", I think @Ly0n is referring to the project age. Maybe we open a new issue to get that merged back in, if you're interested in doing that too @milanych :-)

@milanych
Copy link
Contributor Author

milanych commented Mar 5, 2024

So we need 4 buttons, right? "Recent", "Age", "Downloads", "Stars" ?

@Codeshark-NET
Copy link
Member

So we need 4 buttons, right? "Recent", "Age", "Downloads", "Stars" ?

Yes that sounds right 👍

@Ly0n
Copy link
Member

Ly0n commented Mar 5, 2024

I'm not sure if a new user will be able to understand these shortened versions. Maybe recent issues, project age, downloads and stars?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants