Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): list tags for DocumentDB clusters #6605

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

kagahd
Copy link
Contributor

@kagahd kagahd commented Jan 20, 2025

Context

Until now, only the tags of the DocumentDB instances and snapshots were read out but not the tags of the cluster.

Description

This fix lists also the tags of the cluster.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kagahd kagahd requested review from a team as code owners January 20, 2025 11:18
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.41%. Comparing base (b56d62e) to head (363514e).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6605      +/-   ##
==========================================
- Coverage   89.43%   89.41%   -0.03%     
==========================================
  Files        1182     1182              
  Lines       33790    33797       +7     
==========================================
- Hits        30219    30218       -1     
- Misses       3571     3579       +8     
Flag Coverage Δ
prowler 89.41% <71.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.41% <71.42%> (-0.03%) ⬇️
api ∅ <ø> (∅)

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kagahd , good catch!!

@MrCloudSec MrCloudSec added backport-to-v3 Backport PR to the v3 branch backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.1 Backport PR to the v5.1 branch labels Jan 20, 2025
@MrCloudSec MrCloudSec merged commit bbba0ab into prowler-cloud:master Jan 20, 2025
12 of 14 checks passed
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Jan 20, 2025
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v3
v4.6
v5.1

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v3 Backport PR to the v3 branch backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.1 Backport PR to the v5.1 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants