Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudwatch): NoneType object is not iterable #6671

Conversation

HugoPBrito
Copy link
Member

Context

cloudwatch_log_group_not_publicly_accessible check is giving this error:

cloudwatch_log_group_not_publicly_accessible -- TypeError[15]: 'NoneType' object is not iterable

Description

A validation has been added to check if the object we are going to iterate over is None or not to avoid it.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners January 23, 2025 16:09
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (ad189b3) to head (ffdb4d3).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6671      +/-   ##
==========================================
+ Coverage   89.35%   89.36%   +0.01%     
==========================================
  Files        1182     1182              
  Lines       33815    33816       +1     
==========================================
+ Hits        30214    30220       +6     
+ Misses       3601     3596       -5     
Flag Coverage Δ
prowler 89.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.36% <100.00%> (+0.01%) ⬆️
api ∅ <ø> (∅)

@jfagoagas jfagoagas added backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch backport-to-v5.1 Backport PR to the v5.1 branch backport-to-v5.2 Backport PR to the v5.2 branch labels Jan 23, 2025
@MrCloudSec MrCloudSec merged commit 998c551 into master Jan 23, 2025
15 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-6090-fix-cloudwatch-log-group-not-publicly-accessible-error branch January 23, 2025 17:27
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Jan 23, 2025
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6
v5.0
v5.1
v5.2

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch backport-to-v5.1 Backport PR to the v5.1 branch backport-to-v5.2 Backport PR to the v5.2 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants