-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudsql): add trusted client certificates case for cloudsql_instance_ssl_connections
#6682
fix(cloudsql): add trusted client certificates case for cloudsql_instance_ssl_connections
#6682
Conversation
cloudsql_instance_ssl_connections
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6682 +/- ##
==========================================
- Coverage 89.38% 89.36% -0.02%
==========================================
Files 1182 1182
Lines 33816 33816
==========================================
- Hits 30226 30221 -5
- Misses 3590 3595 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@puchy22 Looks great! This PR gives me a good idea of what the corresponding test case would need to look like. Thank you for adjusting that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!! 👏🏼👏🏼👏🏼👏🏼
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Context
Check
cloudsql_instance_ssl_connections
was not supporting for trusted clients certificates that is a way of SSL connection.Fix #6668
Description
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.