feat(schedules): Rework daily schedule to always show the next scan #6700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and scheduled_at calculation
…scans-right-after-creating-a-provider
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6700 +/- ##
==========================================
- Coverage 93.52% 93.41% -0.11%
==========================================
Files 67 70 +3
Lines 6330 6412 +82
==========================================
+ Hits 5920 5990 +70
- Misses 410 422 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jfagoagas
previously approved these changes
Jan 28, 2025
There was a problem hiding this comment.
I've just tested out the functionality and works as expected, thanks @vicferpoy 👏
…scans-right-after-creating-a-provider
vicferpoy
dismissed stale reviews from jfagoagas and AdriiiPRodri
via
a47652b
vicferpoy
deleted the
PRWLR-6072-scheduled-scans-must-appear-in-scans-right-after-creating-a-provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this development, daily schedules will always add a new
scheduledscan, with the correctscheduled_atdatetime in its details. We are soft deprecating thenext_scan_atfield for it.In addition, we added a new Django migration to migrate the former scheduled scans to this "format".
When adding new providers for the first time, after requesting
POST /schedules/daily, a newscheduledscan withavailablestate will be created right away and will be executed once a worker is available, improving the UX.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.