Feature/improvements #154
Merged
Feature/improvements #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vladamatena
commented
Jul 24, 2024
•
vladamatena
commented
- Update Python, run check wit all version we use
- Run CI on pull requests (currently runs on branch push which does not seem to work for cross repo pull requests)
- Bump CI helpers to avoid warnings and future problems
ondratu
requested changes
Jul 24, 2024
.github/workflows/tests.yml
Outdated
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: 3.8 | ||
| python-version: 3.12 |
There was a problem hiding this comment.
Please add:
- 3.10 too, we use 3.10 in Connect
- 3.11 - that use HT90, which will use PrusaErrroCodes too
There was a problem hiding this comment.
Added matrix configuration to run with multiple Pythons.
vladamatena
force-pushed
the
feature/improvements
branch
from
0e6ebbf to
7307792
Compare
ondratu
approved these changes
Jul 24, 2024
Use matrix to run wilh all Pyhtons we use.
vladamatena
force-pushed
the
feature/improvements
branch
from
41f33eb to
5ebe0e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.