Fix typo "beet" in GCODE_CROPPED #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error text for GCODE_CROPPED recently popped up on my MK4S. The wording felt a little off, and this felt like a typo snuck in. > "As a result, it might have beet not executed correctly." is now phrased as > "As a result, it might not be executed correctly."
|
@vorner Hi! I saw you had reviewed/approved a previous typo-related PR and wondering if you wouldn't mind looking at this one. |
|
Hello, this error message is displayed AFTER the cropped gcode was already executed, so the past tense is IMO correct there. The typo of course not. |
|
@CZDanol Good call out! I revised the wording to match the proper tense. |
CZDanol
approved these changes
Dec 12, 2024
|
This typo also exist in the language files. See prusa3d/Prusa-Firmware-Buddy#4411 for more information. |
|
Those texts are generated from this config file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error text for GCODE_CROPPED recently popped up on my MK4S. The wording felt a little off, and this felt like a typo snuck in.