Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Fix footer update after selecting None #4345

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

GUI: Fix footer update after selecting None #4345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/gui/footer/footer_line.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ bool FooterLine::Create(footer::Item item_id, size_t index) {

if (item_id >= footer::Item::_count) {
item_id = footer::Item::none;
} else if (item_id == footer::Item::none) {
unregister(index);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not call positionWindows, which it probably should in some cases (at least according to the previous code).

return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is rather debatable whether this should call true or false. From the previous code, it rather seems like the function should return true if an item is changed (and in that case, and only in that case, it should call reposition). This code does not follow that logic.

But looking around, it seems like the return value is not used anywhere, so it would perhaps be best to just turn it into a procedure.

}

auto &item = items[index];
Expand Down