Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FW version check timeout comment #4412

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix FW version check timeout comment #4412

wants to merge 2 commits into from

Conversation

nmschulte
Copy link
Contributor

No description provided.

CZDanol
CZDanol reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@CZDanol CZDanol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your input. The comment is indeed wrong - but what about removing the comment altogether instead? It basically just duplicates the code, without really adding any value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CZDanol CZDanol CZDanol left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmschulte @CZDanol