-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimisation: calculate steps per unit reciprocal at compile time #336
Conversation
All values in bytes. Δ Delta to base
|
Interesting, even though you are introducing new variables, the resulting code is significantly shorter than before, good job. Please have a look at the unit tests failing .... oh, it's just the comment 🤦
|
Yup it is causing all PRs to fail. Only someone with admin access to the repo can fix it. We had the same problem on Prusa-Firmware repo before. |
@3d-gussner has admin rights 😉 |
@3d-gussner it looks like some of the unit tests are timing out on this PR. Not sure if its random, but I don't see it in the other PRs. I haven't looked into if the unit tests need updating. |
9644d71
to
efc2ce1
Compare
Using the reciprocal allows us to use multiplication instead of division at runtime. This commit removes 7 divison operations at run time. Change in memory: Flash: -210 bytes SRAM: 0 bytes
efc2ce1
to
87a1862
Compare
All motion tests fail. Also testing with M404 results in IDLER CANNOT HOME |
I think I see what the problem is... its with |
Using the reciprocal allows us to use multiplication instead of division at runtime.
This commit removes 7 divison operations at run time.
Change in memory:
Flash: -210 bytes
SRAM: 0 bytes