tests: improvements around idler homing #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idler is only put on hold, and resumed after a user event is seen. We must ensure the idler is engaged before feeding to FINDA.
We never home Idler and Selector at the same time. I think we did early perhaps, but now the selector always waits for the idler homing to be valid.
Add handling for HomingFailed which can cause the tests to timeout. Add checks for HomeForward and HomeBack
|
All values in bytes. Δ Delta to base
|
Automated Test Code Coverage ReportView details...
TOTAL: 2727 lines of code, 2029 lines executed, 74% covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes were made in #337 but I'm creating this separate PR since these changes apply to the current main branch.
Changes:
SimulateIdlerHomingcall in Load Filament error recovery. The homing is never invalidated in this state machine. Instead we should be simulating the idler engaging on the slot with the error.mm::MovableBase::HomingFailedthen the unit test will timeout. Also added checks formm::MovableBase::HomeForwardandmm::MovableBase::HomeBack.SimulateFailedHomeFirstTime, it was attempting to homing the idler and selector at the same time... which is forbidden today. Instead, simulate a successful idler homing, and proceed to simulate a failed selector homing.