Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise EEPROM access in a few places by reading/writing larger blocks #4466

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Optimise EEPROM access in a few places by reading/writing larger blocks #4466

merged 2 commits into from
Oct 27, 2023

Conversation

gudnimg
Copy link
Collaborator

@gudnimg gudnimg commented Oct 25, 2023

Saves a bit of flash memory

@github-actions
Copy link

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG -254 0 245894 5633 8058 2559
MK3_MULTILANG -252 0 245180 5642 8772 2550

@gudnimg gudnimg requested review from 3d-gussner and DRracer October 25, 2023 17:47
@3d-gussner 3d-gussner added this to the FW 3.14.0 milestone Oct 26, 2023
3d-gussner
3d-gussner approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@3d-gussner 3d-gussner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gudnimg gudnimg merged commit 3b10c61 into prusa3d:MK3 Oct 27, 2023
5 checks passed
@gudnimg gudnimg deleted the eeprom-optimisations branch October 27, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3d-gussner 3d-gussner 3d-gussner approved these changes

@DRracer DRracer Awaiting requested review from DRracer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
FW 3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gudnimg @3d-gussner