PFW-1523 Add the S parameter to M79
#4479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My plan is to re-use this function in M79 in a later commit. The firmware doesn't have a dedicated parser like Marlin 2.1 so this is my attempt to not duplicate the parsing of a quoted string in G-codes Change in memory (MK3S+ Multilang): Flash: -50 bytes SRAM: 0 bytes
Change in memory: Flash: +112 bytes SRAM: +3 bytes
|
All values in bytes. Δ Delta to base
|
Saves 36 bytes of flash
gudnimg
changed the title
S parameter to M79S parameter to M79
3d-gussner
requested changes
Nov 6, 2023
3d-gussner
reviewed
Nov 6, 2023
3d-gussner
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4460
Add the
Sparameter toM79. When the M79 timer is running, the S parameter will change the letters on "percentage done" text on the status screen to something customizable. The requirement was this be at most 2 characters and only activated when the M79 timer is running (when printing).Another UI change is "USB" text is removed. Instead "HO" is shown which stands for "Host". "USB" wasn't really accurate when printing through a raspberry pi.
In the image below, "PL" stands for PrusaLink.
I've tried to minimize memory usage and re-used the parsing from
M862.3 P. I testedM862.3 Pby disabling and enabling the MMU and in both cases it works fine.TODO:
unquoted_string()does not modifystrchr_pointer.