Remove sm4 line xyze UI #4766
Merged
Remove sm4 line xyze UI #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change in code size. Reason for removing this function is just to reduce lines of code that is maintained.
|
All values in bytes. Δ Delta to base
|
|
Nice these changes now pass Github CI :) I guess we can review it then. |
|
👍 Builds work as expected in VSCode (CMake) windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up my fork and found this branch. Changing the file from
.cto.cppwas not building correctly in the Travis build, I never found out why but I suspect it was cache related. Now that we're using CMake it should run fine...Creating this PR to check if CI passes