PFW-1561 Fix MMU unload issue #4771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
EFCE_FIXED is set to EFCE_OK only when the printer is not active. This resolves an issue where, while the print job is paused due to the fan error; if you allow the extruder to cool down below 50°C, then the printer will still try to heat up the extruder to do the unload. Instead of allowing both EFCE_OK and EFCE_FIXED. Only allow unloading if fan_check_error == EFCE_OK
print_job_timer is stopped at this point so print_job_timer.paused() always yields false. For this reason here we only need to check did_pause_print. I think this makes the code a bit easier to read and gives a reason why we are clearing the flag at the end of the function.
|
@3d-gussner Good news, I can confirm this fixes the issue. I could reproduce the issue on current MK3 branch (5aa6748) and with this pull request the MMU no longer unloads when a print is aborted due to fan error, when the temperature is below 50°C. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
EXTRUDER_AUTO_FAN_TEMPERATURE(50°C). This can take ~10 minutes.Expected result: MMU should NOT re-heat the nozzle and unload the filament