Refactor getDefaultVariantForFormat function to simplify control flow…

… and ensure format validation.
przemek83 · Jan 4, 2025 · a9d0e45 · a9d0e45
1 parent 596009e
commit a9d0e45
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/src/Utilities.cpp b/src/Utilities.cpp
@@ -53,20 +53,14 @@ QString getXlsxTemplateName()
 
 QVariant getDefaultVariantForFormat(ColumnType format)
 {
-    switch (format)
-    {
-        case ColumnType::STRING:
-            return QVariant(QMetaType(QMetaType::QString));
+    Q_ASSERT(format != ColumnType::UNKNOWN);
 
-        case ColumnType::NUMBER:
-            return QVariant(QMetaType(QMetaType::Double));
+    if (format == ColumnType::NUMBER)
+        return QVariant(QMetaType(QMetaType::Double));
 
-        case ColumnType::DATE:
-            return QVariant(QMetaType(QMetaType::QDate));
+    if (format == ColumnType::DATE)
+        return QVariant(QMetaType(QMetaType::QDate));
 
-        default:
-            Q_ASSERT(false);
-    }
     return QVariant(QMetaType(QMetaType::QString));
 }