Refactor header content generation to use a static regular expression…

… for improved performance and readability.
przemek83 · Jan 4, 2025 · c3577f4 · c3577f4
1 parent 3abe6ec
commit c3577f4
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/ExportXlsx.cpp b/src/ExportXlsx.cpp
@@ -77,10 +77,9 @@ QByteArray ExportXlsx::generateHeaderContent(const QAbstractItemModel& model)
     for (int j{0}; j < columnCount; ++j)
     {
         QString header{model.headerData(j, Qt::Horizontal).toString()};
+        static const QRegularExpression regExp{QStringLiteral("[<>&\"']")};
         const QString clearedHeader(
-            header
-                .replace(QRegularExpression(QStringLiteral("[<>&\"']")),
-                         QStringLiteral(" "))
+            header.replace(regExp, QStringLiteral(" "))
                 .replace(QStringLiteral("\r\n"), QStringLiteral(" ")));
         headersContent.append("<c r=\"" + columnNames_[j]);
         headersContent.append(R"(1" t="str" s="6"><v>)" +