This repository has been archived by the owner on Nov 15, 2024. It is now read-only.
ADAPT-1802: [hydra-publish] Adapt data classification changes according to our policy #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman-minz
requested review from
RenjithSomasekharan,
abhivermaaa,
shreedhar-kc and
aadit-chugh
shreedhar-kc
suggested changes
Dec 21, 2023
ingestors/kafka/src/main/scala/hydra/kafka/programs/TopicMetadataV2Validator.scala
Outdated
Show resolved
Hide resolved
…taken care by script already
shreedhar-kc
previously approved these changes
Dec 21, 2023
aadit-chugh
previously approved these changes
Jan 10, 2024
aman-minz
dismissed stale reviews from aadit-chugh and abhivermaaa
via
976d3a8
shreedhar-kc
approved these changes
Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new Data Classification values in our system. As advised, we are also accepting the old values of data classification. However, the supported values/symbols for data classification in the v1 and v2 metadata schema are as per our policy. The old values are transformed to new values in DVS before they are sent to kafka-broker.
Please note that when an old value of data classification is received in the request, we take care of retaining it by storing in SubDataClassification field.
DataClassification:
{ "name": "dataClassification", "type": { "type": "enum", "name": "DataClassification", "namespace": "hydra.kafka.model", "symbols": [ "Public", "InternalUse", "Confidential", "Restricted" ] } }SubDataClassification:
{ "name": "subDataClassification", "type": [ "null", { "type": "enum", "name": "SubDataClassification", "namespace": "hydra.kafka.model", "symbols": [ "Public", "InternalUseOnly", "ConfidentialPII", "RestrictedFinancial", "RestrictedEmployeeData" ] } ], "default": null }Supported Values in request => Values sent to Kafka: