Fix scandir DD_LOCK #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Be sure the
__lock_release_recursive(dirp->dd_lock);is being called before theclosedir(dirp);otherwise it will crash as thedirp->dd_lockis going to be deleted inclosedirand on top of that thedirpis freed also inclosedir.This issue has been there in
newlibfor years, however, it wasn't noticed because first of all LOCK API looks to be barely used, and secondly because it also requires the flagHAVE_DD_LOCKto be enabled.Cheers.