Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Bug: 11.7 - button Bei individueller Schriftart und Schriftgröße überlappen die Icons mit der Schrift. (nur Firefox) #6645

Closed
Sommerli2 opened this issue Jul 18, 2024 · 5 comments · Fixed by #7260
Closed

🐞 Bug: 11.7 - button Bei individueller Schriftart und Schriftgröße überlappen die Icons mit der Schrift. (nur Firefox) #6645

Sommerli2 opened this issue Jul 18, 2024 · 5 comments · Fixed by #7260
Assignees
@sdvg
Labels
a11y-retest-2024 bug Something isn't working Button created-by: kolibri-team Created by KoliBri-Team theme:Default Default theme issue

Comments

@Sommerli2
Copy link

Sommerli2 commented Jul 18, 2024 •
edited by github-actions bot
Loading

Link to the code that reproduces this issue:

2.1.3

Can you categorise where the error occurs?

Which browser or operating system do you used to test KoliBri?

Firefox

How to reproduce issue?

image

Current vs. Expected:

Werden Icons verwendet, überlappen die Inhalte teilweise image
image
image

Environment informations:

 Build: f30a4d4 at 2024-06-28T04:09:59.035Z Windows 10
 Firefox:115.12.0esr (64-Bit) ```
@Sommerli2 Sommerli2 added the bug Something isn't working label Jul 18, 2024
@github-actions github-actions bot added v created-by: kolibri-team Created by KoliBri-Team theme:Default Default theme issue Button and removed a11y-retest-2024 labels Jul 18, 2024
@laske185
Copy link
Contributor

Bitte hier testen: https://develop--kolibri-public-ui.netlify.app/

@laske185 laske185 moved this from Backlog to 🚹 A11y-Test in KoliBri Board Sep 19, 2024
@AntnSaj
Copy link

AntnSaj commented Sep 27, 2024

Bei "Button icons" wird immer noch der Rand überlappt (siehe Screenshot).
Image

@AntnSaj AntnSaj assigned laske185 and unassigned laske185 Sep 27, 2024
@AntnSaj AntnSaj moved this from 🚹 A11y-Test to 📄 Ready in KoliBri Board Sep 30, 2024
@AntnSaj AntnSaj removed their assignment Sep 30, 2024
@anicyne anicyne self-assigned this Oct 4, 2024
anicyne added a commit that referenced this issue Oct 7, 2024
@anicyne
Fix icon overlap in buttons
Loading
Loading status checks…
74aa64d 
Refs: #6645
@anicyne anicyne mentioned this issue Oct 7, 2024
Closed
@anicyne anicyne linked a pull request Oct 7, 2024 that will close this issue
Fix icon overlap in buttons #6907
Closed
@laske185 laske185 moved this from 🏗 In progress to 🚹 A11y-Test in KoliBri Board Oct 10, 2024
@anicyne anicyne removed a link to a pull request Oct 16, 2024
Fix icon overlap in buttons #6907
Closed
@anicyne anicyne removed their assignment Oct 17, 2024
@laske185 laske185 removed the v label Oct 25, 2024
@laske185
Copy link
Contributor

Dieses Ticket bitte nochmal nachtesten. Wurde durch ein anderes Ticket behoben.

@Roman-Use
Copy link

Inhalte überlappen weiterhin, sodass der Rand/Border vom Button teilweise verschwindet. Dies wurde wie im Ticket geschrieben auf https://develop--kolibri-public-ui.netlify.app/ getestet.
2024-11-07_14h42_29
2024-11-07_14h43_00
2024-11-07_14h43_35
2024-11-07_14h43_59

@deleonio
Copy link
Contributor

Man sollte zuerst im default Theme schauen, woran es liegt. Ggf. verursacht das default Theme den Fehler. Wenn nicht, kann man ja prüfen, ob der Fehler im Basis-Style eher zu lösen wären.

@laske185 laske185 moved this from 🏗 In progress to 📄 Ready in KoliBri Board Nov 18, 2024
@sdvg sdvg self-assigned this Jan 21, 2025
@sdvg sdvg moved this from 📄 Ready to 🏗 In progress in KoliBri Board Jan 21, 2025
sdvg added a commit that referenced this issue Jan 21, 2025
@sdvg
Fix icon line-height for edge cases
Loading
Loading status checks…
2e5fbfe 
Refs: #6645
@sdvg sdvg mentioned this issue Jan 21, 2025
Merged
5 tasks
@sdvg sdvg linked a pull request Jan 21, 2025 that will close this issue
Fix icon line-height for edge cases #7260
Merged
5 tasks
publicuibot bot pushed a commit that referenced this issue Jan 21, 2025
@sdvg @publicuibot
Update all snapshots$
Loading
Loading status checks…
3013c98 
$
Refs: #6645
@sdvg sdvg moved this from 🏗 In progress to 🔍 Review in KoliBri Board Jan 21, 2025
deleonio added a commit that referenced this issue Jan 29, 2025
@deleonio
Merge branch 'develop' of https://github.com/public-ui/kolibri into 6…
Loading
Loading status checks…
73ac792 
…645-fix-button-icon-overlap-v3

Refs: #6645
publicuibot bot pushed a commit that referenced this issue Jan 29, 2025
@deleonio @publicuibot
Update all snapshots$
Loading
Loading status checks…
1578962 
$
Refs: #6645
@github-project-automation github-project-automation bot moved this from 🔍 Review to ✅ Done in KoliBri Board Jan 29, 2025
sdvg added a commit that referenced this issue Feb 3, 2025
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 6176-toas…
Loading
Loading status checks…
57b268d 
…t-dialog

* 'develop' of github.com:public-ui/kolibri: (1915 commits)
  Fix concurrency group syntax in dod-checker workflow
  Remove auto file generator workflow
  remove some prepack scripts
  Update all snapshots$ $ Refs: #7310
  Fix duplicate import of 'h' in shadow.tsx component
  Fix formRef initialization to handle null value in FormErrorList component
  Enhance error list functionality: improve scrolling and focus behavior for error links
  Enhance error list rendering: add smooth scroll and focus behavior for alert component
  Update all snapshots$ $ Refs: #6645
  update kolibri deps and lock
  Update all snapshots$ $ Refs: #7178
  Extend input fields aria-described property to all types of messages, not just errors
  Unify JSDoc property descriptions
  Fix table double layers and hyphens
  Fix Drawer controlled mode: Allow to open with an initial _open property
  Update all snapshots$ $ Refs: #7178
  KolInputRange: Fix width calculation for number input
  Update all snapshots$ $ Refs: #6645
  Fix icon line-height for edge cases
  Increase contrast for card box-shadow
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdvg sdvg

Labels
a11y-retest-2024 bug Something isn't working Button created-by: kolibri-team Created by KoliBri-Team theme:Default Default theme issue
Projects
KoliBri Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix icon line-height for edge cases public-ui/kolibri
7 participants
@sdvg @deleonio @laske185 @Sommerli2 @AntnSaj @anicyne @Roman-Use