Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon line-height for edge cases #7260

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Fix icon line-height for edge cases #7260

merged 4 commits into from
Jan 29, 2025

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Jan 21, 2025 •
edited
Loading

Refs: #6645

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@sdvg sdvg linked an issue Jan 21, 2025 that may be closed by this pull request
🐞 Bug: 11.7 - button Bei individueller Schriftart und Schriftgröße überlappen die Icons mit der Schrift. (nur Firefox) #6645
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Netlify Draft Deployment
URL: https://6799aec13713b6ef0531a8e3--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/6799aec13713b6ef0531a8e3

@sdvg sdvg marked this pull request as ready for review January 21, 2025 17:38
deleonio
deleonio previously approved these changes Jan 29, 2025
View reviewed changes
@deleonio deleonio force-pushed the 6645-fix-button-icon-overlap-v3 branch from fb1e1b7 to 3013c98 Compare January 29, 2025 04:13
@deleonio deleonio merged commit c392eda into develop Jan 29, 2025
9 checks passed
@deleonio deleonio deleted the 6645-fix-button-icon-overlap-v3 branch January 29, 2025 04:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sdvg @deleonio