Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used new CryptoModule from kotlin SDK. #280

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Used new CryptoModule from kotlin SDK. #280

merged 7 commits into from
Oct 16, 2023

Conversation

marcin-cebo
Copy link
Contributor

@marcin-cebo marcin-cebo commented Sep 29, 2023

fix: Improve security of crypto implementation.

Improved security of crypto implementation by adding enhanced AES-CBC cryptor.

feat: Add crypto module

Add crypto module that allows configure SDK to encrypt and decrypt messages.

Copy link
Contributor

@kleewho kleewho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why another such file in the project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Cucumber test there is step:
@then("Successfully decrypt an encrypted file with legacy code")

that uses FileEncryptionUtilKT.decrypt
There are two FIleEncrytionUtil. One is .java and second .kt copied from kotlin into java project
package com.pubnub.api.crypto

@marcin-cebo
Copy link
Contributor Author

@pubnub-release-bot release as v6.4.0

@marcin-cebo marcin-cebo merged commit 6feef15 into master Oct 16, 2023
5 checks passed
@marcin-cebo marcin-cebo deleted the mc_crypto_java branch October 16, 2023 10:53
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants