Fix missing partial crypto functionality #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
approved these changes
Oct 26, 2023
| } | ||
| } | ||
|
|
||
| public function setCrypto(CryptoModule $cryptoModule) |
There was a problem hiding this comment.
FYI. In Kotlin/Java it is not possible to setCrypto in PubNub. User can setCrypto only in PNConfiguration.
There was a problem hiding this comment.
As I understood @techwritermat asked for that - maybe he will ask you too ;o
Xavrax
approved these changes
Oct 27, 2023
| } | ||
| } | ||
|
|
||
| public function setCrypto(CryptoModule $cryptoModule) |
There was a problem hiding this comment.
As I understood @techwritermat asked for that - maybe he will ask you too ;o
| if ($this->cryptoModule) { | ||
| return $this->cryptoModule; | ||
| } else { | ||
| return $this->configuration->getCrypto(); |
There was a problem hiding this comment.
Is this line creates a new cryptomodule on missing?
There was a problem hiding this comment.
if it has the cipher keyset up in config then will get the module. Else it raises an exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.