Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disallowJavaScriptCode rule #114

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,20 @@ Pug must not contain any ID literals.
div(id='id')
```

# disallowJavaScriptCode: `true`

Pug must not contain any JavaScript code.

```pug
//- Invalid
- var someVariable = 1
div(class=someVariable)
div= someVariable
if someVariable
each item in someVariable
while someVariable
```

# disallowLegacyMixinCall: `true`

The Pug template must not contain legacy mixin call.
Expand Down
40 changes: 40 additions & 0 deletions lib/rules/disallow-javascript-code.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// # disallowJavaScriptCode: `true`
//
// Pug must not contain any JavaScript code.
//
// ```pug
// //- Invalid
// - var someVariable = 1
// div(class=someVariable)
// div= someVariable
// if someVariable
// each item in someVariable
// while someVariable
// ```

var utils = require('../utils');

module.exports = function () {};

module.exports.prototype = {
name: 'disallowJavaScriptCode',

configure: function (options) {
utils.validateTrueOptions(this.name, options);
},

lint: function (file, errors) {
file.addErrorForAllTokensByFilter(function (token) {
return token.type === 'code' ||
token.type === 'each' ||
token.type === 'while' ||
token.type === 'if' ||
token.type === 'else-if' ||
token.type === 'else' ||
token.type === 'case' ||
token.type === 'when' ||
token.type === 'default' ||
(token.type === 'attribute' && token.val !== true && !(/^-?\d*\.?\d*$/.test(token.val) || /^"(?:[^"\\]|\\.)*"$/.test(token.val) || /^'(?:[^'\\]|\\.)*'$/.test(token.val)));
}, errors, 'JavaScript code must not be used');
}
};
48 changes: 48 additions & 0 deletions test/rules/disallow-javascript-code.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
module.exports = createTest;

var assert = require('assert');

function createTest(linter) {
describe('disallowJavaScriptCode', function () {
describe('true', function () {
before(function () {
linter.configure({disallowJavaScriptCode: true});
});

it('should report JavaScript code', function () {
assert.equal(linter.checkString('- var x = 777\nbody= x').length, 2);
});

it('should report JavaScript code in attribute', function () {
assert.equal(linter.checkString('p(x=y)').length, 1);
assert.equal(linter.checkString('p(x=`y`)').length, 1);
assert.equal(linter.checkString('p(x=true)').length, 1);
});

it('should not report JavaScript code in attribute', function () {
assert.equal(linter.checkString('p(x=1)').length, 0);
assert.equal(linter.checkString('p(x="y")').length, 0);
assert.equal(linter.checkString('p(x="y\\"y")').length, 0);
assert.equal(linter.checkString('p(x=\'y\')').length, 0);
assert.equal(linter.checkString('p(x=\'y\\\'y\')').length, 0);
assert.equal(linter.checkString('input(checked)').length, 0);
});

it('should report JavaScript code in each', function () {
assert.equal(linter.checkString('each a in b\n\t\tp').length, 1);
});

it('should report JavaScript code in while', function () {
assert.equal(linter.checkString('while true\n\t\tp').length, 1);
});

it('should report JavaScript code in condition', function () {
assert.equal(linter.checkString('if true\n\t\tp\nelse if true\n\tp\nelse\n\tp').length, 3);
});

it('should report JavaScript code in case', function () {
assert.equal(linter.checkString('case x\n\twhen y\n\t\tp\n\tdefault\n\t\tp').length, 3);
});
});
});
}