Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable highlighting in catalog_controller behind a flipper feature #3817

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Enable highlighting in catalog_controller behind a flipper feature #3817

merged 1 commit into from
Nov 10, 2023

Conversation

christinach
Copy link
Member

@christinach christinach commented Nov 7, 2023 •
edited
Loading

closes #3795

Enable highlighting in catalog_controller for title_display,author_display,title_vern_display #3795 #3794 #3796

@christinach
Copy link
Member Author

christinach commented Nov 7, 2023 •
edited
Loading

This pr works with this pul_solr PR. Tests fail because pul_solr PR is not yet merged.
regarding pul_solr/pull/374 ideally we want a separate search handler so that we dont build a highlighting element on the fly with the current search handler we use in solr.

@christinach
Copy link
Member Author

christinach commented Nov 7, 2023 •
edited
Loading

current implementation activates highlighting feature in the catalog_controller based on the configuration in pul_solr.
Potential tickets that need to be resolved:

@christinach christinach force-pushed the highlight-3795 branch 7 times, most recently from 04727a3 to b87683f Compare November 10, 2023 15:48
@christinach christinach marked this pull request as ready for review November 10, 2023 15:48
@christinach christinach marked this pull request as draft November 10, 2023 15:52
@christinach @sandbergja @kevinreiss
Enable highlighting in catalog_controller for title_display,author_di…
96252b3 
…splay,title_vern_display #3795 #3794 #3796

Update emphasized query to have em-highlight-query class

Co-authored-by: Jane Sandberg <[email protected]>
Co-authored-by: Kevin Reiss <[email protected]>
@christinach christinach marked this pull request as ready for review November 10, 2023 16:48
sandbergja
sandbergja approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐬

@coveralls
Copy link

Coverage Status

coverage: 95.455% (-0.01%) from 95.465%
when pulling 96252b3 on highlight-3795
into 5b952f2 on main.

@christinach christinach merged commit dedb0d0 into main Nov 10, 2023
11 checks passed
@christinach christinach deleted the highlight-3795 branch November 10, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandbergja sandbergja sandbergja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choose Solr Highlighting Option
3 participants
@christinach @coveralls @sandbergja