-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Beta Banner from PDC Discovery #749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claudiawulee Thanks for taking a swing at this! Instead of removing everything from that banner config, though, would you please just remove the values from production? We want to keep the banner in the other environments.
Sounds good! Thanks for letting me know! |
Well done, @claudiawulee , you found a bug. What should happen is that when you remove the values (but not the environment!) from banner.yml the banner in the UI disappears. I believe we want to keep a place for production values in that file though. We want to make it possible for someone who is not a ruby on rails developer to easily add a banner when needed, possibly under emergency conditions. I think that will be easier if there is already a blank place in the file (i.e., the empty production values in banner.yml) that they can edit. Would you please:
|
Co-authored-by: Claudia Lee <[email protected]>
@bess Thank you for the clarifications! Added logic to not display the blue banner when the values in banner.yml are empty. |
Closes #686