Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Beta Banner from PDC Discovery #749

Merged
merged 10 commits into from
Feb 4, 2025
Merged

Conversation

claudiawulee
Copy link
Contributor

Closes #686

Copy link
Contributor

@bess bess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claudiawulee Thanks for taking a swing at this! Instead of removing everything from that banner config, though, would you please just remove the values from production? We want to keep the banner in the other environments.

@claudiawulee claudiawulee self-assigned this Jan 31, 2025
@claudiawulee claudiawulee marked this pull request as draft January 31, 2025 20:36
@claudiawulee
Copy link
Contributor Author

@claudiawulee Thanks for taking a swing at this! Instead of removing everything from that banner config, though, would you please just remove the values from production? We want to keep the banner in the other environments.

Sounds good! Thanks for letting me know!

@bess
Copy link
Contributor

bess commented Feb 4, 2025

Well done, @claudiawulee , you found a bug. What should happen is that when you remove the values (but not the environment!) from banner.yml the banner in the UI disappears. I believe we want to keep a place for production values in that file though. We want to make it possible for someone who is not a ruby on rails developer to easily add a banner when needed, possibly under emergency conditions. I think that will be easier if there is already a blank place in the file (i.e., the empty production values in banner.yml) that they can edit.

Would you please:

  1. Return the place in banner.yml where the production values go, but leave them blank
  2. Ensure that when values are blank for an environment the banner does not render at all

Screenshot 2025-02-04 at 7 52 29 AM

@claudiawulee
Copy link
Contributor Author

@bess Thank you for the clarifications! Added logic to not display the blue banner when the values in banner.yml are empty.
image

@hectorcorrea hectorcorrea marked this pull request as ready for review February 4, 2025 19:15
@hectorcorrea hectorcorrea merged commit 71a361b into main Feb 4, 2025
4 checks passed
@hectorcorrea hectorcorrea deleted the 686-remove-banner branch February 4, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove beta banner from PDC Discovery
3 participants