Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Beta Banner from PDC Discovery #749

Merged
merged 10 commits into from
Feb 4, 2025
Merged

Removed Beta Banner from PDC Discovery #749

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
83eae94
commented out and removed data from yml file
claudiawulee Jan 31, 2025
4c2f030
readded all environments in banner.yml except production
claudiawulee Feb 4, 2025
d01beeb
left blank production values in banner.yml
claudiawulee Feb 4, 2025
399ce4d
Added a test. Tweaked the logic in the helper a little bit.
hectorcorrea Feb 4, 2025
81c2f3a
Update Circle CI browser-tools
hectorcorrea Feb 4, 2025
4b9c328
Shot in the dark
hectorcorrea Feb 4, 2025
c00254c
Shot in the dark part 2
hectorcorrea Feb 4, 2025
cb1780f
Shot in the dark part 3
hectorcorrea Feb 4, 2025
26fc529
Shot in the dark part 4
hectorcorrea Feb 4, 2025
5a14a40
Shot in the dark part 5 - using version posted today, fingers crossed
hectorcorrea Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/banner_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module BannerHelper
# rubocop:disable Rails/ContentTag
def banner_content
@yaml_data = YAML.load_file('config/banner.yml')
return false if @yaml_data[Rails.env].nil?
return false if @yaml_data.nil? || @yaml_data[Rails.env].nil?
@banner_title = "<h1>#{@yaml_data[Rails.env]['title']}</h1>"
@banner_body = "<p>#{@yaml_data[Rails.env]['body']}</p>"
end
Expand Down
15 changes: 3 additions & 12 deletions config/banner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
---
development:
title: Welcome to the development site
body: Have a look around our new website for the discovery and sharing of research data and <a href="mailto:[email protected]"> let us know what you think</a>. See <a href="https://datacommons.princeton.edu/describe/" target="_blank">How to Submit</a> for instructions on how to publish your research data and code.
test:
title: Welcome to the <i>test</i> site
body: This is a <b>test</b> <a href="mailto:[email protected]">message.</a>
staging:
title: Welcome to Princeton Data Commons Discovery! (Staging)
body: Have a look around our new website for the discovery and sharing of research data and <a href="mailto:[email protected]"> let us know what you think</a>. See our <a href="https://researchdata.princeton.edu/research-lifecycle-guide/getting-started-princeton-data-commons-describe-contributor" target="_blank"> Getting Started as a Princeton Data Commons Contributor</a> guide for instructions on how to publish your research data and code.
production:
title: Welcome to Princeton Data Commons Discovery!
body: Have a look around our new website for the discovery and sharing of research data and <a href="mailto:[email protected]"> let us know what you think</a>. See <a href="https://datacommons.princeton.edu/describe/" target="_blank">How to Submit</a> for instructions on how to publish your research data and code.
# development:
# title: Welcome to the development site
# body: Have a look around our new website for the discovery and sharing of research data and <a href="mailto:[email protected]"> let us know what you think</a>. See <a href="https://datacommons.princeton.edu/describe/" target="_blank">How to Submit</a> for instructions on how to publish your research data and code.