-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Traefik/Finding Aids] Finding Aids Bot Wall #5911
Conversation
cb5dbf4
to
0bd9c47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray for bot protection. Just one question, really.
- 128.112.200.245/32 | ||
- 128.112.201.34/32 | ||
# PUL Network, trust these. | ||
- 128.112.0.0/16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we can use the existing list of PUL IP ranges from the nginxplus role? I know these don't change often (maybe not ever) but I dislike having the same list in two places - double the maintenance, double the risk of drift.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question! Hmm. Can you ticket that? We might be able to store the list of IPs as a nomad variable provisioned by ansible, but it'd take some figuring to see how to store an array there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 128.112.200.245/32 | ||
- 128.112.201.34/32 | ||
# PUL Network, trust these. | ||
- 128.112.0.0/16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
@@ -0,0 +1,40 @@ | |||
http: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
@@ -37,7 +45,7 @@ server { | |||
proxy_set_header X-Forwarded-Proto https; | |||
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | |||
proxy_set_header X-Real-IP $remote_addr; | |||
proxy_cache pulfalight-stagingcache; | |||
proxy_cache pulfalight-prodcache; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, nice catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK! Thanks @tpendragon
This makes the bot wall work for facets from the home page.
We're not getting reports of users getting stuck, and the bots are quickly diversifying their IPs enough to avoid the low challenge wall.
f97261d
to
a5fe62a
Compare
This adds the bot wall to finding aids, via a few updates:
findingaids.princeton.edu/?f[]=
tofindingaids.princeton.edu/catalog?f[]=
to let it be caught by the bot wall.IMPORTANT NOTE: To make this work, @kayiwa had to allow access from the lib subnet to the finding aids machines.