Add route and controller for allowing sysadmins to import projects from Mediaflux #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolyncole
force-pushed
the
project-import
branch
from
b417d62 to
1cf034d
Compare
carolyncole
force-pushed
the
project-import
branch
from
1cf034d to
29fa7cc
Compare
carolyncole
force-pushed
the
project-import
branch
from
29fa7cc to
b4a2cb3
Compare
carolyncole
commented
Feb 7, 2025
| @@ -45,10 +45,8 @@ def create_test_root_namespace(user) | |||
|
|
|||
| # When connect_to_mediaflux is true reset the mediaflux server and make sure it is setup for the tests | |||
| RSpec.configure do |config| | |||
| config.before(:each) do |ex| | |||
| if ex.metadata[:connect_to_mediaflux] | |||
There was a problem hiding this comment.
We are connecting to mediaflux in any test now, so we should clean mediaflux before any test
JaymeeH
approved these changes
Feb 7, 2025
Comment on lines
+2
to
+11
| class ProjectImportController < ApplicationController | ||
| def run | ||
| if current_user.eligible_sysadmin? | ||
| ProjectImport.run_with_report(mediaflux_session: current_user.mediaflux_session) | ||
| else | ||
| flash[:alert] = I18n.t(:access_denied) | ||
| redirect_to root_path | ||
| end | ||
| end | ||
| end |
| flash[:alert] = "Access Denied" | ||
| flash[:alert] = I18n.t(:access_denied) |
There was a problem hiding this comment.
I assume this is for accessibility?
Comment on lines
+22
to
+25
| # skip projects not part of the current namespace in dev & test mode since we have both mediaflux instances in one server | ||
| if Rails.env.development? || Rails.env.test? | ||
| next unless project_metadata["path"].starts_with?(Rails.configuration.mediaflux["api_root_collection_namespace"]) | ||
| end |
Comment on lines
+44
to
+55
| describe "##run_with_report" do | ||
| let (:user) {FactoryBot.create :sysadmin, mediaflux_session: SystemUser.mediaflux_session} | ||
| it "creates projects for project in Mediaflux" do | ||
| new_project = FactoryBot.create(:approved_project, project_directory: "test-request-service") | ||
| new_project.mediaflux_id = nil | ||
| ProjectMediaflux.create!(project: new_project, user:) | ||
| new_project.destroy | ||
|
|
||
| expect{ described_class.run_with_report(mediaflux_session: user.mediaflux_session) }.to change { Project.count }.by(1) | ||
| end | ||
|
|
||
| end |
| @@ -45,10 +45,8 @@ def create_test_root_namespace(user) | |||
|
|
|||
| # When connect_to_mediaflux is true reset the mediaflux server and make sure it is setup for the tests | |||
| RSpec.configure do |config| | |||
| config.before(:each) do |ex| | |||
| if ex.metadata[:connect_to_mediaflux] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1272