Fix missing/bad address line handling #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes (indirectly) _bfd_dwarf2_find_nearest_line, which returns
bogus results in certain occasions (e.g. when therere are line numbers which
refer to address 0 in the dwarf section). Also sometimes it didn't return
anything at all which was visible in objdump even though the debug sections had
the necessary information.
original commit from riscv-binutils-1.30:
20230942fe3674150ab661738d72f1618b3d4b1b
original message:
PR21957, addr2line incorrectly handles non-increasing sequences in line table
PR 21957
* dwarf2.c (new_line_sorts_after): Remove end_sequence comparison.
(add_line_info): Always put end_sequence last.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes (indirectly) _bfd_dwarf2_find_nearest_line, which returns
bogus results in certain occasions (e.g. when therere are line numbers which
refer to address 0 in the dwarf section). Also sometimes it didn't return
anything at all which was visible in objdump even though the debug sections had
the necessary information.
original commit from riscv-binutils-1.30:
20230942fe3674150ab661738d72f1618b3d4b1b
original message:
PR21957, addr2line incorrectly handles non-increasing sequences in line table