Centralize resource names in settings package #1093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
For some specific scenarios, after upgrading the operator, some errors may appear.
scenario1:
scenario2:
Any installation with pulp-web.
This PR centralizes the k8s resource names definition in a unique place. It will be helpful in case we decide to allow multiple instances of Pulp running in the same namespace.
Postgres
Since we are trying to avoid name conflicts, we had to change the name of the volume used by postgres sts, but this is an immutable field and when the operator tries to modify it it will get into an infinite reconcile error loop. To workaround this situation:
pulp-web
Another breaking change is in case the installation has a pulp-web deployment. This PR changes a label/labelselector from pulp-web deployment so, after upgrading the operator, it can get into an infinite loop trying to update the deployment and getting an error because the field (labelselector) is immutable. To workaround this error just delete the pulp-web deployment and a new one will be provisioned with the new label.
ref: #1025
[noissue]