Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility script to detect dangling PRCs in structured content #1191

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add utility script to detect dangling PRCs in structured content #1191

merged 1 commit into from
Jan 8, 2025

Conversation

hstct
Copy link
Contributor

@hstct hstct commented Nov 20, 2024

[noissue]

@hstct hstct force-pushed the add_pulpcore_management_command_for_prc_orphans branch from 571a81c to b173a98 Compare November 20, 2024 15:31
@quba42
Copy link
Collaborator

quba42 commented Nov 21, 2024

I see the following naming issue: "orphaned content" has a well defined meaning in Pulp (content that is not in any repository version). The PRCs we are looking for here, do not meet that definition, so the term "orphan" is likely to lead people astray.

I am not sure what a better term might be, but here are some possibilities: "Repo orphaned PRC", "dangling PRC", "dangling structured content". I am open to better suggestions.

@hstct hstct force-pushed the add_pulpcore_management_command_for_prc_orphans branch from b173a98 to 472ec96 Compare November 21, 2024 14:19
@hstct hstct force-pushed the add_pulpcore_management_command_for_prc_orphans branch from 472ec96 to 75ad78c Compare November 21, 2024 14:19
@hstct hstct changed the title Add utility script to detect orphaned PRCs in structured content Add utility script to detect dangling PRCs in structured content Nov 21, 2024
@hstct
Copy link
Contributor Author

hstct commented Nov 21, 2024

I see the following naming issue: "orphaned content" has a well defined meaning in Pulp (content that is not in any repository version). The PRCs we are looking for here, do not meet that definition, so the term "orphan" is likely to lead people astray.

I am not sure what a better term might be, but here are some possibilities: "Repo orphaned PRC", "dangling PRC", "dangling structured content". I am open to better suggestions.

I agree orphan is not good in the context. I changed it dangling content.

@hstct hstct marked this pull request as ready for review November 21, 2024 14:20
quba42
quba42 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@quba42 quba42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and merged downstream (identical change).

@hstct hstct merged commit 2bf6e39 into pulp:main Jan 8, 2025
12 checks passed
@quba42 quba42 deleted the add_pulpcore_management_command_for_prc_orphans branch January 9, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quba42 quba42 quba42 approved these changes

Assignees
No one assigned
Labels
no-changelog no-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hstct @quba42