Ignore release version and description if null #960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing release version or description to python-deb fails if the fields are None. fixes pulp#959
quba42
reviewed
Nov 20, 2023
| @@ -415,15 +415,15 @@ def __init__( | |||
| self.release["Label"] = release.label | |||
| if release.suite: | |||
| self.release["Suite"] = release.suite | |||
| if release.version != NULL_VALUE: | |||
| if release.version and release.version != NULL_VALUE: | |||
There was a problem hiding this comment.
I think the idea is that this can't be null: https://github.com/pulp/pulp_deb/blob/main/pulp_deb/app/models/content/metadata.py#L27 because we did not set null=True for the field definition. Resulting in this DB migration: https://github.com/pulp/pulp_deb/blob/main/pulp_deb/app/migrations/0024_add_release_fields.py which should have defaulted the field to the string '__!!!NULL VALUE!!!__'.
I am guessing this is another case of your instance having added this field with a different migration than the one that was eventually merged.
There was a problem hiding this comment.
Confirmed. Thanks for the insight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing release version or description to python-deb fails if the fields are None.
fixes #959