-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick fix for AnyType ruby bindings #3679
Conversation
The JSONField was yielding an empty type on the schema, which broke bindings generation. This replaces drf serializers.JSONField with a custom one that is an OpenApi 'object' type. Closes: pulp#3639
Given the diff in the clients specs, the unexpected presence of the We don't test the bindings on PR, so to assert that manually you can:
|
So this seems reasonable to me, but @mdellweg is probably a better judge of correctness. I'd like us to file an issue to revert this change once a "correct" fix is ready though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the would work in isolation for these pulp_rpm fields.
Maybe you want to call it JSONObjectField
.
Backport to 3.27: 💚 backport PR created✅ Backport PR branch: Backported as #3680 🤖 @patchback |
Backport to 3.26: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 2e0c293 on top of patchback/backports/3.26/2e0c2933675c0ce41d8ac5c801f8d0dbc54349d8/pr-3679 Backporting merged PR #3679 into main
🤖 @patchback |
Quicker alternative to #3653 for fixing #3639
I must add that this is not the "correct way" of fixing it, but its quick and safe (in the sense that it leaves us in a similar state we had before, where all jsonfields were recognized as Objects). Its not the correct way because:
Reference