Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #3757/5ccddf72 backport][3.22] Fixed create_modulemd() stacktrace when handling malformed modulmd. #3758

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/3756.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed stacktrace from create_modulemd() when trying to report an error.
12 changes: 6 additions & 6 deletions pulp_rpm/app/modulemd.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,13 @@ def create_modulemd(modulemd, snippet):
"Got unexpected data for module {}-{}-{}-{}-{}: "
"profiles failed to parse properly"
).format(
data[PULP_MODULE_ATTR.NAME],
data[PULP_MODULE_ATTR.STREAM],
data[PULP_MODULE_ATTR.VERSION],
data[PULP_MODULE_ATTR.CONTEXT],
data[PULP_MODULE_ATTR.ARCH],
new_module[PULP_MODULE_ATTR.NAME],
new_module[PULP_MODULE_ATTR.STREAM],
new_module[PULP_MODULE_ATTR.VERSION],
new_module[PULP_MODULE_ATTR.CONTEXT],
new_module[PULP_MODULE_ATTR.ARCH],
)
log.warn(msg)
log.warning(msg)
else:
profiles[name] = rpms

Expand Down
Loading