[PULP-277] Adapt to 'CONTENT_ORIGIN can be null'. #3865
Conversation
ggainey
force-pushed
the
3856_null_origin
branch
5 times, most recently
from
c966438 to
989f86a
Compare
|
Once pulp/pulpcore#6175 merges I'll remove the temporary distribution_base_url fixture and undraft. |
| @pytest.mark.parallel | ||
| def test_config_repo_auto_distribute( | ||
| setup_empty_distribution, rpm_publication_api, rpm_distribution_api, monitor_task | ||
| ): | ||
| """Whether config.repo is properly served using auto-distribute.""" | ||
| repo, pub, dist = setup_empty_distribution | ||
|
|
||
| body = {"repository": repo.pulp_href, "publication": None} | ||
| body = {"repository": repo.pulp_href, "publication": None, "generate_repo_config": True} |
There was a problem hiding this comment.
Explanation for adding this explicit setting:
When running in my local environment, partial-update via the client-bindings is forcing the setting of anything with a default. This was causing the test to fail - since it "assumes" that generate_repo_config stays true for the life of the test.
Dumping the incoming-data at this point in the test (when I am not setting generate_repo_config explicitly) looks like this:
[pulp] | 'data': {'generate_repo_config': False,
[pulp] | 'hidden': False,
[pulp] | 'publication': None,
[pulp] | 'repository': '/pulp/api/v3/repositories/rpm/rpm/01949dd6-e044-716e-bd47-769b41657a93/'},
Changing the values via pulp-cli in my environment does not evidence this behavior - incoming data looks like this:
[pulp] | 'data': {'base_path': 'dist3'},
"Feels like" an openapi-generator difference between what's in my dev-env and Reality. Impact on this PR is nil, but something to watch out for.
Removed tests/upgrade directory - these tests don't test anything current, and have not actually been run in years. fixes pulp#3856.
ggainey
force-pushed
the
3856_null_origin
branch
from
989f86a to
ae4941d
Compare
fixes #3856.