feat: add timeout for container sync #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not adding the timeout, but increasing the default. Can you adjust the commit message? |
jackhodgkiss
force-pushed
the
fix-container-timeout
branch
from
9ffaf1f to
d729385
Compare
Sure the commit message has been adjusted. |
mdellweg
approved these changes
Apr 15, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written in issues/135 ansible_sync module is failing due timeouts and has been resolved with PR#136. However this problem appears to impact other modules as mentioned in issues/148.
I have encountered this problem with container_sync with repeated timeouts. Apply the same fix as found in PR#136 has resolved all timeouts.