Implement merge person/clusters on Face recognition backend. Part of … #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issue pulsejet#285 Just try to make the patch as simple as possible without changing a single line of behavior in recognize. The warning that you can only merge with named people is important, and while I personally don't understand why we would merge unnamed people, it is a feature that the recognize backend supports.
|
Can we please have a release with this fix? Thanks. |
|
I can confirm the fix worked. I produced a prerelease, untarred it into my apps folder, and BAM, it worked. Here is a link to the file: https://cloud.rudd-o.com/s/seiEZdAyZnkJzm7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…issue #285
Just try to make the patch as simple as possible without changing a single line of behavior in recognize.
The warning that you can only merge with named people is important, and while I personally don't understand why we would merge unnamed people, it is a feature that the recognize backend supports.