Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated SDK generation @ aws-cloudformation-user-guide 19dc52cd3f2007d6d268b65b739ffb5ebf8c1e76 #1770

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

pulumi-bot
Copy link
Contributor

@pulumi-bot pulumi-bot commented Oct 14, 2024

Automated SDK generation @ aws-cloudformation-user-guide 19dc52cd3f2007d6d268b65b739ffb5ebf8c1e76 #1770

No new resources or functions.

Copy link
Contributor

Does the PR have any schema changes?

Found 8 breaking changes:

Resources

  • "aws-native:ec2:TransitGatewayRouteTable":
    • 🟡 inputs: "tags": items type changed from "#/types/aws-native:index:CreateOnlyTag" to "#/types/aws-native:index:Tag"
    • 🟡 properties: "tags": items type changed from "#/types/aws-native:index:CreateOnlyTag" to "#/types/aws-native:index:Tag"
  • 🟡 "aws-native:glue:Crawler": properties: "awsId" missing output "awsId"
  • "aws-native:route53resolver:ResolverRule":
    • 🟡 inputs: "delegationRecord" missing
    • 🟡 properties: "delegationRecord" missing output "delegationRecord"
  • 🟡 "aws-native:sagemaker:ImageVersion": inputs: "version" missing

Functions

  • "aws-native:glue:getCrawler": inputs:
    • 🟡 "id" missing input "id"
    • 🟢 required: "name" input has changed to Required
      No new resources/functions.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.04%. Comparing base (cf71032) to head (498baa8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1770   +/-   ##
=======================================
  Coverage   42.04%   42.04%           
=======================================
  Files          35       35           
  Lines        4759     4759           
=======================================
  Hits         2001     2001           
  Misses       2556     2556           
  Partials      202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0 t0yv0 self-requested a review October 14, 2024 19:53
@t0yv0 t0yv0 merged commit 5ad276d into master Oct 14, 2024
18 checks passed
@t0yv0 t0yv0 deleted the generate-sdk/11321094919-883 branch October 14, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants