Retry GetResource NotFound when creating #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
t0yv0
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1809 +/- ##
==========================================
+ Coverage 45.44% 45.67% +0.22%
==========================================
Files 38 38
Lines 5886 5916 +30
==========================================
+ Hits 2675 2702 +27
- Misses 2988 2991 +3
Partials 223 223 ☔ View full report in Codecov by Sentry. |
corymhall
approved these changes
Nov 7, 2024
flostadler
reviewed
Nov 7, 2024
| ctx context.Context, | ||
| typeName, identifier string, | ||
| ) (map[string]interface{}, error) { | ||
| retryBackoff := retry.NewExponentialJitterBackoff(30 * time.Second) |
There was a problem hiding this comment.
I'd reduce the max duration here a bit. We'd now wait up to ~60 seconds. That seems a bit too long to me.
Eventual consistency delays for those services are usually in the millis.
There was a problem hiding this comment.
I'll send a quick follow-up PR, this one merged already.
t0yv0
added a commit
that referenced
this pull request
Nov 8, 2024
GetResource NotFound backoff introduced in #1809 allowed long time wait periods up to 30 seconds. This change makes the max wait period 3 seconds at this is more appropriate for AWS eventual consistency propagation delays this backoff tries to compensate for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a retry for NotFound errors from GetResource executed right after Create.
Based on the logs from our CI runs we suspect eventual consistency in AWS may cause some resources to fail with NotFound in Get even after WaitForResourceOpCompletion succeeded.
Relates: #1186