Upgrade coredns addon version #1443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
corymhall
approved these changes
Oct 14, 2024
flostadler
reviewed
Oct 14, 2024
| @@ -66,7 +66,7 @@ const cluster4 = new eks.Cluster(`${projectName}-4`, { | |||
| const coredns = new eks.Addon("coredns", { | |||
| cluster: cluster3, | |||
| addonName: "coredns", | |||
| addonVersion: "v1.11.1-eksbuild.9", | |||
There was a problem hiding this comment.
We should rather dynamically fetch the correct version using https://www.pulumi.com/registry/packages/aws/api-docs/eks/getaddonversion/. That way we'll not have to keep updating this
You'll have to do the same for the cluster-py example.
There was a problem hiding this comment.
Closing in favor of #1441 I think that's fixed there with dynamic fetching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1437
CoreDNS addon version used in tests is bumped to the latest available in to compensate for a "version not supported" error discovered by nightly tests:
https://docs.aws.amazon.com/eks/latest/userguide/managing-coredns.html
Related issues (optional)