Add region to kubeconfig #1498
Merged
Add region to kubeconfig #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
corymhall
approved these changes
Nov 19, 2024
t0yv0
approved these changes
Nov 19, 2024
|
This PR has been shipped in release v3.2.0. |
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The generated kubeconfig is missing the region argument. This can lead to issues in many scenarios, e.g. when a user has
AWS_DEFAULT_REGIONset or when they have no default region set and use the provider configuration for setting the pulumi region (i.e.aws:region). This aligns the provider with how the AWS CLI generates the kubeconfig (aws eks update-kubeconfig).This change uses the cluster ARN to identify the cluster's region and sets it in the kubeconfig.
The k8s provider's
kubeconfigproperty will not trigger replacements. Multiple upgrade tests validate this (e.g.aws-profile).Related issues (optional)
Fixes #1038