Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci-mgmt: remove unread field enableAutoRelease from .ci-mgmt.yaml #142

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 18, 2024

This PR removes the unused field enableAutoRelease from .ci-mgmt.yaml. ci-mgmt recently started rejecting unknown fields. This does not cause any change to the semantics of .ci-mgmt.yaml.

Part of pulumi/ci-mgmt#1147

@iwahbe iwahbe self-assigned this Nov 18, 2024
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could we fill out the PR title and description to give context to anyone in the future following along with how to keep their provider up-to-date with the boilerplate.

Copy link

Does the PR have any schema changes?

Found 1 breaking change:

Functions

  • 🔴 "xyz:index/dataSource:DataSource" missing

New functions:

  • index/getDataSource.getDataSource

Maintainer note: consult the runbook for dealing with any breaking changes.

@iwahbe iwahbe changed the title Iwahbe/fix ci mgmt Fix ci-mgmt: remove unread field enableAutoRelease from .ci-mgmt.yaml Nov 18, 2024
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@iwahbe iwahbe merged commit 3b3caf5 into main Nov 18, 2024
21 checks passed
@iwahbe iwahbe deleted the iwahbe/fix-ci-mgmt branch November 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants