ECMA 6 - Constants and variables and Map/Set tests #139
Conversation
|
Hey, thanks for the PR! I see you are fixing the indentation errors... You can run As a general rule, you should add an As for the tests i didn't examine them closely but they look good to me! |
| @@ -0,0 +1,59 @@ | |||
| // Copyright (c) 2013 - present UTN-LIS | |||
There was a problem hiding this comment.
Review indentation. Please take note of unsupported cases for Puma. This will help to define future tasks on the runtime support.
| define(['pumascript'], function (puma) { | ||
|
|
||
| QUnit.module("Ecma6-Map-Set-And-WeakMap-WeakSet-Tests"); | ||
| skip("Map get method", function(assert) { |
| assert.equal(result.value, true); | ||
| }); | ||
|
|
||
| skip("Variable let block scope", function(assert) { |
There was a problem hiding this comment.
Multiple variable asignation.
There was a problem hiding this comment.
| var result = puma.evalPuma("let s = new Set(); s.add('hello').add('goodbye').add('hello'); s.size === 2;"); | ||
| assert.equal(result.value, true); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Add empty line at the end.
|
Really good job! Just small comments! |
pemattio
changed the title
| assert.ok(result.success && result.value === 'undefined'); | ||
| }); | ||
|
|
||
| }); |
Work for the following issues:
#132 and #118